Fix: Check permissions on duplicate pattern and template part actions. #62757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +31 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Jun 21, 2024
| isTemplateOrTemplatePart && | ||
| userCanCreatePostType && | ||
| duplicateTemplatePartAction, | ||
| isPattern && userCanCreatePostType && duplicatePatternAction, |
There was a problem hiding this comment.
Are these both saved as blocks CPTs?
There was a problem hiding this comment.
With that I mean: both patterns and template parts?
There was a problem hiding this comment.
No, patterns are on wp_block/blocks and template parts are on wp_template_part/template_parts. But we are checking if the user can create the post type the actions are being used on userCanCreatePostType: canUser( 'create', resource ). So the same condition can apply to both.
ellatrix
approved these changes
Jun 24, 2024
jorgefilipecosta
deleted the
fix/check-permissions-on-duplicate-pattern-and-template-part-actions
branch
jorgefilipecosta
added a commit
that referenced
this pull request
Jun 25, 2024
jorgefilipecosta
added a commit
that referenced
this pull request
Jun 25, 2024
ellatrix
added
Backported to WP Core
|
Handled in #62823. |
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #62633.
Adds permission checks on the duplicate pattern and template_part actions.
We can not test the check on template_part because it depends on the edit_theme_options capability and as of right now, the user can never see template parts if the capability is not present, but for consistency and in case things change, we should have the check.
Testing Instructions
I pasted the following test code that removes the ability to create patterns (while still allowing to edit them).
I went to wp-admin/site-editor.php?postType=wp_block and I tried to duplicate a pattern and verified the UI did not show that option.