Pattern overrides: Remove caption and href from images with overrides #62775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +113 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Closing this as it was finally decided to follow the other approach instead. |
SantosGuillamot
deleted the
try/remove-caption-and-links-in-image-overrides
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential different alternative approach to #62747, although I must say I am not sure which one is better. Probably the other pull request seems safer.
What?
Fixes #62287 (the remainder of it, the other part was fixed by #62471)
When creating pattern overrides, remove caption and href from images when the "Enable Overrides" option is checked.
Why?
Because it's not supported by block bindings right now.
How?
Changing the save function to remove them when bindings are in the attributes and changing the edit to hide the controls.
Testing Instructions