-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Date Block: Fix PHP warning error #62783
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ametaplus. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This issue was introduced in WP6.6, so I'm giving it the backport label. |
95e1d99
to
47e3c70
Compare
@t-hamano This shouldn't be backported because the original PR wasn't |
@ametaplus mind sharing your WordPress.org username so I can ensure its included in the 6.7 credits listing? |
sure, it is webwurm |
Fixes #62763
Follow-up #62298
What?
This PR fixes a PHP warning error that occurs when "Display last modified date" in the Post Date block is enabled.
Why?
In #62298, the relative time format was added. However, it seems that a check for undefined was missing in one place.
Testing Instructions
Insert a Post Date block into a post and enable "Display last modified date". Do not disable "Default format". Alternatively, use the HTML below:
<!-- wp:post-date {"displayType":"modified"} /-->
No errors should occur on the front end.