Global Styles: Make a shared component for typography and color preview #62829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -11.7 kB (-0.66%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
scruffian
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
force-pushed
the
refactor/typography-examples
branch
from
7425688
to
4d618b2
Compare
|
There's a stray |
MaggieCabrera
approved these changes
Jul 2, 2024
packages/edit-site/src/components/global-styles/variations/variations-typography.js
Outdated
Show resolved
Hide resolved
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ew (WordPress#62829) * Global Styles: Make a shared component for typography and color preview * remove null check that has already happened Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use the same approach to display typography variations that we use for color variations.
Why?
If we use a similar approach to display these presets it will be easier to update them to have shared components. This will be possible once #62827 is merged.
How?
Creates a new
StylesPreviewTypographycomponent similar toStylesPreviewColors.Testing Instructions