Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block.json schema #62917

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Update block.json schema #62917

merged 1 commit into from
Jul 27, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jun 27, 2024

Note

This PR is not for the trunk branch. It is for fixing a block.json schema issue in the WP 6.5 branch.

What?

This PR is to fix missing fields, inconsistencies, etc. in block.json schema in WP6.5.

How?

I looked at the diff between the two branches, wp/6.5 and WP/6.6 (see this comment) and added missing fields and fixed existing fields.

The fields that were changed, why they were changed, and the associated PR are below.

Testing Instructions

Create a JSON file like the one below:

{
	"$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/wp/6.5-fix-block-json-schema/schemas/json/block.json"
}

The code editor should now correctly display the changes made in this PR.

Screenshots or screencast

image

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Jun 27, 2024
@t-hamano t-hamano self-assigned this Jun 27, 2024
@t-hamano t-hamano marked this pull request as ready for review June 27, 2024 09:52
@t-hamano t-hamano requested a review from ajlende as a code owner June 27, 2024 09:52
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano
Copy link
Contributor Author

There are some test failures, but they don't seem to be the result of this PR. In fact, there are some test failures in the HEAD of the wp/6.5 branch.

@gziolo gziolo merged commit 7ed4689 into wp/6.5 Jul 27, 2024
43 of 90 checks passed
@gziolo
Copy link
Member

gziolo commented Jul 27, 2024

Let’s give it a try. Thank you for crafting these changes. It looks like CI is failing also because of reports related to outdated config for browserlist. This is something that probably should be disabled on old branches.

Can we close the issue now?

@t-hamano
Copy link
Contributor Author

Thanks for the review! Yes, #62780 can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants