Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnitControl select disabled state colors #62970

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Fix UnitControl select disabled state colors #62970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad30280
fix unit control select disabled state
matiasbenedetto Jun 28, 2024
f2fa9ca
adding changelog entry
matiasbenedetto Jun 28, 2024
de24652
adding 'bug fixes' subtitle to readme addition
matiasbenedetto Jun 28, 2024
f9d406c
lowe specifity to avoid override :focus styles
matiasbenedetto Jun 28, 2024
9cd4cec
removing redundant css
matiasbenedetto Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug Fixes

- `UnitControl`: Fix colors when disabled. ([#62970](https://github.com/WordPress/gutenberg/pull/62970))

### Internal

- `CustomSelectControlV2`: add root element wrapper. ([#62803](https://github.com/WordPress/gutenberg/pull/62803))
Expand Down
14 changes: 10 additions & 4 deletions packages/components/src/unit-control/styles/unit-control-styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,15 @@ const baseUnitLabelStyles = ( { selectSize }: SelectProps ) => {
box-sizing: border-box;
padding: 2px 1px;
width: 20px;
color: ${ COLORS.gray[ 800 ] };
font-size: 8px;
line-height: 1;
letter-spacing: -0.5px;
text-transform: uppercase;
text-align-last: center;

&:not( :disabled ) {
color: ${ COLORS.gray[ 800 ] };
}
`,
default: css`
box-sizing: border-box;
Expand All @@ -54,13 +57,17 @@ const baseUnitLabelStyles = ( { selectSize }: SelectProps ) => {
height: 24px;
margin-inline-end: ${ space( 2 ) };
padding: ${ space( 1 ) };
color: ${ COLORS.theme.accent };

font-size: 13px;
line-height: 1;
text-align-last: center;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;

&:not( :disabled ) {
color: ${ COLORS.theme.accent };
}
`,
};

Expand Down Expand Up @@ -106,8 +113,7 @@ const unitSelectSizes = ( { selectSize = 'default' }: SelectProps ) => {
justify-content: center;
align-items: center;

&:hover {
color: ${ COLORS.ui.borderFocus };
&:where( :not( :disabled ) ):hover {
box-shadow: inset 0 0 0
${ CONFIG.borderWidth + ' ' + COLORS.ui.borderFocus };
outline: ${ CONFIG.borderWidth } solid transparent; // For High Contrast Mode
Expand Down
Loading