DataViews: Restore preview focus outline in grid layout #62991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: -96 B (-0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I would like to add a backport label to this PR because I consider it a regression that occurred in WP6.6. |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
|
Thank you. I tested on Chrome on Windows 11 |
jameskoster
reviewed
Jul 1, 2024
| @@ -43,7 +43,7 @@ | |||
| overflow: hidden; | |||
| height: 100%; | |||
| width: 100%; | |||
| border-radius: 3px 3px 0 0; | |||
| border-radius: 3px; | |||
There was a problem hiding this comment.
Should we make this 4px?
That would be consistent with other UI's. I don't think we use 3px elsewhere. It would also fix this small discrepancy in the corners, where the background bleeds through between the image and the focus ring:
|
Good catch :) |
t-hamano
force-pushed
the
dataviews/buttuon-focus
branch
from
15df46f
to
a8f8ba9
Compare
|
Thank you for your reviews. The size should now be unified to 4px, and all four corners should be rounded on all screens. By the way, the style around Dataview has changed significantly in the trunk, so this PR resolves the conflict. To backport this PR to WP6.6, cherry-picking will not work, and we will need to manually create a commit with the changes for WP6.6 😅 |
|
Flaky tests detected in a8f8ba9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9745313520
|
carolinan
approved these changes
Jul 2, 2024
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 2, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 7398659 |
There were no problems - the automatic cherry-pick committed the changes correctly and I verified that the wp/6.6 branch showed the focus outline we expected. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62958
What?
This PR fixes an issue where the focus outline was not displayed on the preview button in the grid layout.
Why?
This issue is probably related to #61159 where we unboxed grid items. The box-shadow is invisible because
overflow: hiddenis applied to the preview button wrapper.dataviews-view-grid__media.How?
I removed
overhidden:flowand adjusted the rounded corners. The preview button itself already hasoverflow: hidden, so there should be no problem with the current unboxed style.Testing Instructions
Screenshots or screencast
21545edc7c503b69b0f45801b94be01b.mp4