Replace __experimentalIsFocusable with accessibleWhenDisabled
#63107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
3 tasks
|
Size Change: +39 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Looks good, thanks 👍
In 406ef77 we handle a few ToolbarButton instances, because why not? These were the last usages of __experimentalIsFocusable in production code, so it only made sense to cover them as well IMHO. Feel free to drop the commit if you disagree or if you were planning to address that separately.
On a side note, with the ESLint rule, should we also handle ToolbarButton and any other button components we know about that also pass restProps down to Button? This can totally be done in a separate PR of course.
This reverts commit 406ef77.
mirka
added a commit
that referenced
this pull request
Jul 4, 2024
* Button: Stabilize `__experimentalIsFocusable` prop * Add changelog * Tweak changelog Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Replace `__experimentalIsFocusable` with `accessibleWhenDisabled` (#63107) * Replace `__experimentalIsFocusable` with `accessibleWhenDisabled` * Replace a few more remaining instances * Revert "Replace a few more remaining instances" This reverts commit 406ef77. --------- Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Fix new violation --------- Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* Button: Stabilize `__experimentalIsFocusable` prop * Add changelog * Tweak changelog Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Replace `__experimentalIsFocusable` with `accessibleWhenDisabled` (WordPress#63107) * Replace `__experimentalIsFocusable` with `accessibleWhenDisabled` * Replace a few more remaining instances * Revert "Replace a few more remaining instances" This reverts commit 406ef77. --------- Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Fix new violation --------- Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #62282
What?
Replaces
__experimentalIsFocusablewithaccessibleWhenDisabledon all existingButtons.Why?
For #62282 (extracted to this PR for easier review)
How?
Codemod + manual inspection of the code changes.
Testing Instructions
✅ Linter passes