Merge #63071 into wp/6.6 - Section Styles: Prevent flash of variation styles in post editor #63111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core GitHub repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.6/rest-api.php |
|
Size Change: +31 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
I ran through the testing steps and this is testing nicely, just as in #63071.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Merges #63071 into
wp/6.6#63071 fixed an issue in the post editor where there would be a delayed flash of variation styling as the global styles data was loaded.
Why?
There were merge conflicts when #63071 attempting to cherry pick #63071.
Testing Instructions
Taken from #63071:
Screenshots or screencast
Screen.Recording.2024-07-03.at.1.17.15.PM.mp4
Screen.Recording.2024-07-03.at.1.16.48.PM.mp4