Updated: Pages: Include avatar in Author field. #63142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +134 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Nice, this is working well on Grid and Table layouts. Can we also include it in the List layout? 🤞 |
|
What if I want to turn off the avatars? I've wondered a few times how we could have entries that are composed of multiple fields/values. Another example of this is date and time (I may want to remove the time). Maybe we need a sub-field concept? Or a format concept? For example I could configure a date format, and for authors you could add options for |
|
That's a valid feature, but potentially something that will get covered in #58012. I don't know if it needs to hold up this PR? |
carolinan
reviewed
Jul 8, 2024
| > | ||
| <img | ||
| onLoad={ () => setIsImageLoaded( true ) } | ||
| alt="" |
There was a problem hiding this comment.
Why is the alt text empty?
There was a problem hiding this comment.
Hi @carolinan good question, it was already empty before in this PR I'm just moving code from the previous AuthorField component https://github.com/WordPress/gutenberg/pull/63142/files#diff-4bc1dbbf462da7ed7ab2b76d40ee01a0a2906482b12bea67383ecbb5697176acL119. But I think it should have an alt text at least something simple as "Author Text" is better than nothing, I made that update.
ntsekouras
reviewed
Jul 8, 2024
| @@ -395,6 +396,11 @@ export default function PostsList( { postType } ) { | |||
| value: id, | |||
| label: name, | |||
| } ) ) || [], | |||
| render: ( { item } ) => { | |||
| return ( | |||
There was a problem hiding this comment.
I don't think we should reuse this render field function. Posts list is meant to be reused by every post type eventually, have an API to get the fields by postType, but I see templates a bit different than the 'normal' post types. Maybe I'm wrong, but it wouldn't hurt to duplicate just some code for now.
There was a problem hiding this comment.
Hi @ntsekouras, I applied your suggestion and did not reuse the field from the templates.
ntsekouras
reviewed
Jul 8, 2024
jorgefilipecosta
force-pushed
the
update/Pages-Include-avatar-in-Author-field
branch
from
8add9e0
to
8730110
Compare
Yes, when we have field combination I can do a small refactor to use that, but I guess for now we can merge this one. |
ntsekouras
approved these changes
Jul 9, 2024
| }, | ||
| [ item ] | ||
| ); | ||
| const withIcon = viewType !== LAYOUT_LIST; |
There was a problem hiding this comment.
Nit: let's rename to withAvatar for more clarity. Additionally and also nit is to combine the checks like ` {withAvatar && ( imageUrl ? ... : ) }
youknowriad
reviewed
Jul 9, 2024
| @@ -1,7 +1,16 @@ | |||
| /** | |||
There was a problem hiding this comment.
Unrelated with this PR but this file should be moved to its own components/post-list folder or something, it's not specific to "posts app"
jorgefilipecosta
force-pushed
the
update/Pages-Include-avatar-in-Author-field
branch
from
fc71ee8
to
aabc47d
Compare
|
@jorgefilipecosta it looks like the List layout was missed here. I only see the avatar in the Table or Grid layout. |
|
@jorgefilipecosta Also, I appreciate this is separate, but in the Templates table the author avatar appears in the Table layout, but not the List layout. It would be good to align across. |
andrewserong
added
the
[Feature] DataViews
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
|
Hi @jameskoster with the iterations we did there are avatars, on list, grid, and table on templates and pages. So everything you pointed out should be fixed. Let me know if there is anything related remaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the author avatar on the author field.
Part of: #63128
cc: @jameskoster
Screenshots
Testing Instructions
Assign an email with a gravatar image to one of the other of a page.
Load the pages list and verify the avatar is correctly shown.