Remove permalink_structure from REST API index
#6319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given Gutenberg ended up using a different implementation, and that `permalink_structure` is a writable-option (i.e. better off in settings), I don't think this change is necessary at this time.
pento
approved these changes
Apr 23, 2018
4 tasks
nuzzio
pushed a commit
to nuzzio/gutenberg
that referenced
this pull request
Apr 25, 2018
4 tasks
mkaz
added a commit
that referenced
this pull request
Apr 26, 2018
mkaz
added a commit
that referenced
this pull request
Apr 26, 2018
* Split API init from compat.php to compat-api.php * Split API init into own file * Combine register and compat api into one rest-api.php file * Remove permalink_structure per #6319 * Move new rest api function for theme supports to rest-api.php load file * Move new register routes to api loader file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given Gutenberg ended up using a different implementation, and that
permalink_structureis a writable-option (i.e. better off insettings), I don't think this change is necessary at this time.
Related https://core.trac.wordpress.org/ticket/42465#comment:7