-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor Sidebar: Hide horizontal scrollbar when navigating #63194
Conversation
This issue is very noticeable on Windows OS and Chrome. Hopefully it will be backported to WP6.6 RC3. |
Size Change: +285 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! It's a regression I introduced in #60466. Before that, the overflow-x
style would come from Emotion:
These Emotion styles are defined as styles.navigatorProviderWrapper
here: https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/navigator/styles.ts#L6-L14
But after my PR the NavigatorProvider
is no longer used, so these CSS properties are missing.
To fully fix the regression, you should also add the contain: content
property.
Thanks for the review!
I added |
Thanks! Now the fix should be complete. |
* Site Editor Sidebar: Hide horizontal scrollbar when navigating * Add `contain: content` and comment Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 63641d5 |
…ress#63194) * Site Editor Sidebar: Hide horizontal scrollbar when navigating * Add `contain: content` and comment Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
…ress#63194) * Site Editor Sidebar: Hide horizontal scrollbar when navigating * Add `contain: content` and comment Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Fixes #63192
What?
This PR hides the horizontal scrollbar that appears when navigating in the site editor sidebar.
How?
To be honest, I didn't know the root cause. Maybe it's related to animations when navigating.
The only solution I found was to apply
overflow-x: hidden;
to the sidebar content.Testing Instructions
Screenshots or screencast
Before
before.mp4
After
after.mp4