Global styles: tweak block background position preview height #63225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
69 tasks
|
Size Change: +1.03 kB (+0.06%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Nice one! Add a 2px border radius to the gray square ($radius-block-ui), and 👍 👍 from me. A quick check from @WordPress/gutenberg-design might also be nice. |
jasmussen
approved these changes
Jul 8, 2024
Done in 2f129be 
|
|
I'll merge, but always happy to do follow ups! |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
…ess#63225) * Add a gray background for the focal picker image preview, with a max-height of 180px * Add border and border radius to focal point picker image container Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ess#63225) * Add a gray background for the focal picker image preview, with a max-height of 180px * Add border and border radius to focal point picker image container Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? How?
This PR adds a gray background for the focal picker image preview, with a max-height of 180px.
Props to @jasmussen
See: #60100 (comment)
Why?
Trying to come up with a compromise in relation to varying image dimensions.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Desktop screens
2024-07-08.13.52.31.mp4
Mobile screens
2024-07-08.13.54.43.mp4