Post editor: increase specificity bottom padding #63288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Thanks for the fix! It appears to work correctly in all scenarios.
- Classic Theme, Post Editor is iframed:
- Classic Theme, Post Editor is not iframed:
- Block Theme, Post Editor is iframed,
useRootPaddingAwareAlignmentsistrue:
- Block Theme, Post Editor is iframed,
useRootPaddingAwareAlignmentsisfalse:
The following two points cannot be tested in the usual way on the Gutenberg plugin. This is because if the Gutenberg plugin is enabled and the theme is a block, the editor will always be iframed.
I temporarily removed the || ( isGutenbergPlugin && isBlockBasedTheme ) condition and tested a block theme, non-iframe editor.
- Block Theme, Post Editor is not iframed,
useRootPaddingAwareAlignmentsistrue:
- Block Theme, Post Editor is not iframed,
useRootPaddingAwareAlignmentsisfalse:
Another issue I noticed while testing this PR is that when the editor is not iframed because a meta box is present, the bottom padding is not applied:
On the other hand, when the meta box is not present but a v2 or lower block is registered and the editor is not iframed, the bottom padding is applied.
However, I found that this issue also occurs in WP6.5, so I don't think it's a blocker for this PR.
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 9baef2c |
github-actions
bot
added
the
Backported to WP Core
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Increases the specificity of the body bottom padding to override any padding set by global styles.
Why?
Fixes #63278.
How?
Set to 0-1-0. Alternatively we could use
!important, but I guess we better avoid that if we know the specificity needed.Testing Instructions
See #63278.
Testing Instructions for Keyboard
Screenshots or screencast