Add: Permission checks to avoid 403 errors on non admin roles. #63296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jorgefilipecosta
commented
Jul 9, 2024
| _globalStylesId | ||
| ) | ||
| : undefined; | ||
| const userId = getCurrentUser()?.id; |
There was a problem hiding this comment.
Ideally, we would do canUser( 'read', 'global_styles' ) but this is not working even for admins so it is probably another bug we should check.
There was a problem hiding this comment.
Let's add inline comments here. It's probably worth opening an issue for REST API changes.
There was a problem hiding this comment.
Hi @Mamaduka, thank you for the review. I added comments and created an issue as suggested.
|
Size Change: +182 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Jul 10, 2024
Comment on lines
+142
to
+153
| const userId = getCurrentUser()?.id; | ||
| const canEditThemeOptions = | ||
| userId && getUser( userId )?.capabilities?.edit_theme_options; |
There was a problem hiding this comment.
Same here: Let's add a comment regarding getUser( userId )?.capabilities?.edit_theme_options usage.
jorgefilipecosta
force-pushed
the
add/permision-checks-to-avoid-403-on-the-editor
branch
2 times, most recently
from
990eba6
to
a203f63
Compare
|
Thanks, @jorgefilipecosta! It looks like we missed a spot in Additionally, it might be a good idea to start using the new syntax for |
jorgefilipecosta
force-pushed
the
add/permision-checks-to-avoid-403-on-the-editor
branch
from
a203f63
to
c1f467b
Compare
|
Hi @Mamaduka,
Nice catch the check was added there.
I updated to the new syntax. |
Mamaduka
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Thanks, @jorgefilipecosta!
Tested with the author role and couldn't spot any 403 errors.
jorgefilipecosta
deleted the
add/permision-checks-to-avoid-403-on-the-editor
branch
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ress#63296) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60987
Adds permission checks for site settings and global styles retrieval on the editor package to avoid 403 HTTP request errors currently happening when a non-admin role like an editor loads the post editor.
Testing Instructions for Keyboard
With a user whose role is editor, I created a new page and verified on the browser console that there are no 403 HTTP requests (on trunk there are).