Grid: Place new block after currently selected block when using slash inserter and splitting text #63333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.2 kB (+0.07%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Hmm, this isn't fixing the issue for me:
I think the problem is occupiedRects isn't refreshing when the amount of gridItems changes, possibly because the object itself hasn't changed?
|
So weird— it looks like the call to |
… seems broken" This reverts commit 9c5e811.
noisysocks
added
[Type] Experimental
|
I figured out what's going on! There's a Not sure how to fix this yet. I asked in https://github.com/WordPress/gutenberg/pull/61915/files#r1673421903 whether the typography For now I think let's ignore this. |
…r and block splitting
|
Added 1adc921 which updates the placement logic in |
noisysocks
changed the title
tellthemachines
approved these changes
Jul 11, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
… inserter and splitting text (WordPress#63333) * useGridLayoutSync: Keep layout in sync regardless of whether Grid is selected * Don't use bulk version of updateBlockAttributes() for now. It seems broken * Revert "Don't use bulk version of updateBlockAttributes() for now. It seems broken" This reverts commit 9c5e811. * useGridLayoutSync: Update placement logic to accomodate slash inserter and block splitting Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #57478.
Currently in
trunkif you use the slash inserter in a manual grid, or split a block (press Enter while typing text in a paragraph), the newly created block is inserted into the top-left-most empty cell.This PR changes that so that the newly created block is positioned after the previously selected block. Specifically, it begins at the bottom right cell of the previously selected block and scans left→right and top→bottom for the first empty cell. It will auto create rows if needed.
To test, you'll need to disable the
useEffectinpackages/block-editor/src/components/global-styles/typography-panel.js. See #63333 (comment). Here's a patch that does that: