Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Text: Add border support #63542

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

aaronrobertshaw
Copy link
Contributor

Part of: #43241

What?

Adopts border support for Media and Text block.

Why?

  • Offers greater design flexibility
  • Improves consistency in design tooling with other blocks

How?

  • Adopts all the available border block supports

Testing Instructions

  • In the site editor, add a Media Text block to a page
  • Style via Global Styles and confirm the editor and frontend display correctly
  • Override the global styles on the block instance and confirm they display appropriately in the editor and frontend

Screenshots or screencast

Screen.Recording.2024-07-15.at.12.51.34.PM.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Media & Text Affects the Media & Text Block labels Jul 15, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well for me in the post and site editors, in global styles, and in overrides at the individual block level 👍

Similar to the discussion in adding the border support to the Gallery block in #63428, I notice that the Media & Text block does not clip the image when we set a heavy border radius:

image

Since the consensus over in #63428 (comment) was to allow border radius even if the block doesn't clip, I don't think it's an issue here, particularly as padding can be set on this block.

LGTM! 🚀

@aaronrobertshaw
Copy link
Contributor Author

Since the consensus over in #63428 (comment) was to allow border-radius even if the block doesn't clip, I don't think it's an issue here, particularly as padding can be set on this block.

A possible follow-up could be to explore inheriting border-radius on the inner image but combined with the ability to add padding to the media and text block, I'm not sure how well it would work in practice.

Ultimately, I think refactoring this block to use an inner Image block, is our best bet. It would then allow optional control over the inner image border-radius.

As per the linked consensus, let's lean into greater design freedom and merge this 👍

@aaronrobertshaw aaronrobertshaw merged commit b453bd9 into trunk Jul 16, 2024
67 checks passed
@aaronrobertshaw aaronrobertshaw deleted the add/media-text-border-support branch July 16, 2024 06:32
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 16, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
@fabiankaegy fabiankaegy mentioned this pull request Oct 1, 2024
97 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants