Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote: Add border support #63544

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Quote: Add border support #63544

merged 1 commit into from
Jul 16, 2024

Conversation

aaronrobertshaw
Copy link
Contributor

Part of: #43241

What?

Adopts border support for the Quote block.

Why?

  • Offers greater design flexibility
  • Improves consistency in design tooling with other blocks

How?

  • Adopts all the available border block supports

Testing Instructions

  • In the site editor, add a Quote block to a page
  • Style via Global Styles and confirm the editor and frontend display correctly
  • Override the global styles on the block instance and confirm they display appropriately in the editor and frontend

Screenshots or screencast

Screen.Recording.2024-07-15.at.1.00.24.PM.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Quote Affects the Quote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jul 15, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Jul 15, 2024
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All testing nicely in the post and site editors, global styles, and overriding at the individual block level.

image

LGTM! 🚀

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aaronrobertshaw aaronrobertshaw merged commit 4dbb870 into trunk Jul 16, 2024
68 checks passed
@aaronrobertshaw aaronrobertshaw deleted the add/quote-border-support branch July 16, 2024 06:14
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 16, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
@t-hamano
Copy link
Contributor

It seems that when text alignment (center or right) is applied to this block, the theme style overrides the block-instance border, so the intended border is not applied. Do we need to reduce the CSS specificity of my theme style?

Below is a screenshot from Emptytheme:

image

@aaronrobertshaw
Copy link
Contributor Author

Thanks for flagging that @t-hamano, I'll get a fix up for the theme styles shortly.

@aaronrobertshaw
Copy link
Contributor Author

A quick fix for the theme alignment styles and plain block style is up in #64045.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants