-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Links: Add border block support #63629
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping into the design tool consistency efforts @akasunil 🙇
This PR tests as advertised for me and helps round out the Social Links design tools given the block already supports background color and padding.
✅ Social Links border is configurable via Global Styles
✅ Global Styles apply correctly in the editor and frontend
✅ Block instance borders take precedence over global styles
✅ Block instance borders display correctly in both the editor and frontend
Screen.Recording.2024-07-17.at.3.54.39.PM.mp4
Nice work! I'll get this merged and update the border tracking issue accordingly.
P.S. To help encourage others that may be less familiar with global styles and block supports, would you mind updating the PR description here, and the other open block support PRs, with more detailed test instructions? Ensuring the block support adoption works correctly is slightly more involved than the current instructions suggest, that's all.
Sure thing! |
Co-authored-by: akasunil <sunil25393@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
What?
Add border block support to the
Social Links
block.Part of #43247
Why?
Social Links
block is missing border support.How?
Adds the border block support in block.json
Testing Instructions
Social Links
border is configurable via Global StylesSocial Links
block and Apply the border stylesScreenshots or screencast
In backend:
In frontend: