Update: Pages: Trash view should default to table layout try 2. #63652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +238 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
It's working for me, thanks for applying the same on the Posts data view 👍 |
jorgefilipecosta
deleted the
update/Pages-Trash-view-should-default-to-table-layout-try-2
branch
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…Press#63652) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
priethor
added
the
[Feature] DataViews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63128.
This is the second attempt for #63138, which was previously reverted at #63481 due to causing a test failure on the trunk. The test failure did not occur on the branch itself.
The test failure was legitimate; the issue was that when switching from the "All pages" with table layout to the trash view, the table layout was maintained. However, when switching back to "All pages," the layout switched to list view instead of maintaining the table view.
This PR resolves that issue. Now, we have logic in place to ensure that when an automatic switch to table layout occurs because the draft view becomes active, the system will switch back to the previously active view instead of defaulting to the list view.
cc: @WordPress/gutenberg-design, I would appreciate, if someone could retest and ensure everything is working as expected. Thank you in advance 😊
Testing Instructions
Open
/wp-admin/site-editor.php?postType=page.Switch to the trash view, and confirm that the table layout becomes active.
Change to the all pages view and ensure that the list layout becomes active again.
Next, open
wp-admin/site-editor.php?postType=page&layout=table.Switch to the trash view and verify that the table layout remains active.
Switch to the all pages view and confirm that the table layout continues to remain active.