Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time To Read: Add border block support #63776

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

akasunil
Copy link
Member

What?

Add border block support to the Time To Read block.

Part of #43247

Why?

Time To Read block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

  • Go to Global Styles setting ( under appearance > editor > styles > edit styles > blocks )
  • Make sure that Time To Read block's border is configurable via Global Styles
  • Verify that Global Styles are applied correctly in the editor and frontend
  • Edit template/page, Add Time To Read block and Apply the border styles
  • Verify that block styles take precedence over global styles
  • Verify that block borders display correctly in both the editor and frontend

Watch attached video for more information.

Screenshots or screencast

Blog-Home-.-Template-.-gutenberg-.-Editor-.-WordPress.2.webm

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Time to Read Affects the Time to Read Block labels Jul 21, 2024
@akasunil akasunil marked this pull request as ready for review July 21, 2024 16:17
@akasunil akasunil requested a review from ajitbohra as a code owner July 21, 2024 16:17
Copy link

github-actions bot commented Jul 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @akasunil 👍

It is testing well for me but before we push ahead with this, I'd like to seek some extra opinions on whether the border controls should be shown by default. Particularly, given the dimension controls here are also hidden by default.

@jameskoster and @richtabor should we make these border controls optional similar to the suggestion here: #63543 (comment)?

packages/block-library/src/post-time-to-read/block.json Outdated Show resolved Hide resolved
@jameskoster
Copy link
Contributor

@aaronrobertshaw yes I think that's a good suggestion; available but hidden by default.

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good @akasunil 👍

✅ Global border styles apply correctly
✅ Block instance styles override global styles
✅ Box sizing takes into account border when parent enforces width

🚢

Screen.Recording.2024-07-30.at.5.53.08.PM.mp4

@akasunil akasunil merged commit c2c8cef into trunk Jul 30, 2024
62 checks passed
@akasunil akasunil deleted the add/timetoread-border-support branch July 30, 2024 09:43
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Time to Read Affects the Time to Read Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants