-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time To Read: Add border block support #63776
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @akasunil 👍
It is testing well for me but before we push ahead with this, I'd like to seek some extra opinions on whether the border controls should be shown by default. Particularly, given the dimension controls here are also hidden by default.
@jameskoster and @richtabor should we make these border controls optional similar to the suggestion here: #63543 (comment)?
@aaronrobertshaw yes I think that's a good suggestion; available but hidden by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good @akasunil 👍
✅ Global border styles apply correctly
✅ Block instance styles override global styles
✅ Box sizing takes into account border when parent enforces width
🚢
What?
Add border block support to the
Time To Read
block.Part of #43247
Why?
Time To Read
block is missing border support.How?
Adds the border block support in block.json
Testing Instructions
Time To Read
block's border is configurable via Global StylesTime To Read
block and Apply the border stylesWatch attached video for more information.
Screenshots or screencast
Blog-Home-.-Template-.-gutenberg-.-Editor-.-WordPress.2.webm