Block editor settings: add missing global styles links dependencies #63823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
commented
Jul 22, 2024
| @@ -353,6 +353,7 @@ function useBlockEditorSettings( settings, postType, postId, renderingMode ) { | |||
| setIsInserterOpened, | |||
| sectionRootClientId, | |||
| globalStylesData, | |||
| globalStylesLinksData, | |||
There was a problem hiding this comment.
Discussion of whether this variable needs to be renamed, or alternatives to the delivery of global styles data to the block editor via settings: #60100 (comment)
|
Size Change: +2 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
LGTM 👍
I smoke tested as per the test instructions and didn't spot any regressions. While the discussion on renaming or moving the globalStylesLinksData is ongoing, I think it makes sense to land this. It should mean it isn't missed when a rename does happen.
I also noticed that I missed updating the location of the background image control in #63551. I can create a separate follow-up to explore whether it should live under the colors in the global styles sidebar as it does in the block inspector.
Sounds great, thanks for testing this one too. |
|
PR tweaking the location of the background panel is available in #63888. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to:
Adds the
globalStylesLinksDatadependency to the useMemo dependency list.Thanks to @youknowriad for catching it.
Why?
The
globalStylesLinksDatadependency was missing from the useMemo dependency list.How?
Add the
globalStylesLinksDatadependency to the useMemo dependency list.Testing Instructions
Smoke test that background images with relative paths in theme.json appear as they should in the editor.
Here's some test JSON that can be used with TT4:
{ "$schema": "../../schemas/json/theme.json", "version": 3, "settings": { "appearanceTools": true }, "styles": { "background": { "backgroundImage": { "url": "file:./assets/images/art-gallery.webp" }, "backgroundAttachment": "fixed" } } }In the Site Editor, check that: