-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Clarify that the site icon is a back button using an animation #63986
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
.edit-site-editor__editor-interface { | ||
opacity: 1; | ||
transition: opacity 0.1s ease-out; | ||
@include reduce-motion("transition"); | ||
@include reduce-motion( "transition" ); | ||
|
||
&.is-loading { | ||
opacity: 0; | ||
|
@@ -17,3 +17,60 @@ | |
display: flex; | ||
justify-content: center; | ||
} | ||
|
||
.edit-site-editor__view-mode-toggle { | ||
/* stylelint-disable -- Disable reason: View Transitions not supported properly by stylelint. */ | ||
view-transition-name: toggle; | ||
/* stylelint-enable */ | ||
position: fixed; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Something about this commit caused the icon to sit low in distraction free. Commenting here because removing the fixed position resolves it in my testing Screen.Recording.2024-08-02.at.12.00.00.PM.movThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix in #64261 |
||
top: 0; | ||
left: 0; | ||
height: $header-height; | ||
width: $header-height; | ||
z-index: 100; | ||
|
||
.components-button { | ||
color: $white; | ||
height: 100%; | ||
width: 100%; | ||
border-radius: 0; | ||
overflow: hidden; | ||
padding: 0; | ||
display: flex; | ||
align-items: center; | ||
justify-content: center; | ||
&:hover, | ||
&:active { | ||
color: $white; | ||
} | ||
|
||
&:focus { | ||
box-shadow: none; | ||
} | ||
} | ||
|
||
.edit-site-editor__view-mode-toggle-icon { | ||
svg, | ||
img { | ||
background: $gray-900; | ||
display: block; | ||
} | ||
} | ||
} | ||
|
||
.edit-site-editor__back-icon { | ||
position: absolute; | ||
top: 0; | ||
left: 0; | ||
width: 60px; | ||
height: 60px; | ||
display: flex; | ||
align-items: center; | ||
justify-content: center; | ||
background-color: hsla(0, 0%, 80%); | ||
pointer-events: none; | ||
|
||
&.has-site-icon { | ||
background-color: hsla(0, 0%, 100%, 0.6); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you add
undefined
here intentionally or by accident?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to tell at this point 😬 I don't remember