Add lightbox option in gallery block link control #64014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: +223 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a39977f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10420044127
|
…update/gallery-block-image-link-control-options
…update/gallery-block-image-link-control-options
…update/gallery-block-image-link-control-options
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@dcalhoun I might need your assistance once more with mobile unit test failure here. It ask me to update snapshots with default |
👋🏻 @akasunil thanks for the mention. It took me a little while to identify the root issue, but it relates to the lack of full support for I opened #64448 addressing the issue. Please feel free to merge it into your branch as you see fit. |
t-hamano
reviewed
Aug 13, 2024
Currently, `__experimentalFeatures` is only partially implemented for the native mobile editor. Recent changes to the shared Gallery block component included a reference to this missing key via the `useSettings` Hook. Setting a default, empty value ensure exceptions are not thrown. Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: akasunil <sunil25393@git.wordpress.org>
…update/gallery-block-image-link-control-options
…update/gallery-block-image-link-control-options
t-hamano
reviewed
Aug 20, 2024
…update/gallery-block-image-link-control-options
t-hamano
reviewed
Aug 21, 2024
…llery-block-image-link-control-options
|
Thank you @madhusudhand @t-hamano and @dcalhoun. I'll merge this PR. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Add link control as toolbar option in gallery * Add link option constant for lightbox * Add expand on lick option in link control * Add class into menugroup component for info text style * Add styles for info text in link control of popover of gallery block * Add info text for lightbox option in link control for gallery block * Add action for lightbox option in gallery block link control * Show lightbox option only when lightbox UI is enabled * Disable lightbox when other link option is selected in gallery block * Remove unneccessory constant * Conditionally apply the lightbox attribute based on defatult setting * Fix lightbox default option issue for gallery block on page load * Highlight link to option in gallery block when selected * update condition to Highlight link to option * Fix lightbox attribute issue for default state of linkTo option * fix: Set empty default `block` settings value (WordPress#64448) Currently, `__experimentalFeatures` is only partially implemented for the native mobile editor. Recent changes to the shared Gallery block component included a reference to this missing key via the `useSettings` Hook. Setting a default, empty value ensure exceptions are not thrown. Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: akasunil <sunil25393@git.wordpress.org> * Change lightbox option lable and address other feedback * Move lightbox logic to getHrefAndDestination function * Remove highlight of LinkTo option in gallery block * Remove css for info text of lightbox option * Refactor getHrefAndDestination function to for lightbox additional attributes --------- Co-authored-by: akasunil <sunil25393@git.wordpress.org> Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
|
"First do it, then make it. Then make it work" - this is nightmare, as only theme.json could disable this and we NEED to disable this whole pseudo-lightbox zooming as it's not even in alpha, but in Core. I would rather want to see how to block it until it's ready. THAT would be NICE. |
|
@bystrzan You can also disable lightbox from global styles of image block. see below video for more info. Dashboard-.-gutenberg-.-WordPress.webm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Expand on clickoption is missing from gallery blockLink Tocontrol.Why?
Image block link control have
Expand on clickoption which basically enables the lightbox on image. Gallery block link control have all other option from image block, ExceptExpand on clickoption.How?
Add
Expand on clickoption in gallery blockLink Tocontrol.Testing Instructions
Expand on clickoption is available under link controlExpand on clickoption function and compare it withImageblock's lightbox functionalityTesting Instructions for Keyboard
Screenshots or screencast