Block Insertion: Clear the insertion point when selecting a different block or clearing block selection #64048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
|
Size Change: +46 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
looks like the e2e failures could be legitimate? |
scruffian
force-pushed
the
fix/63867
branch
2 times, most recently
from
8633579
to
0154bec
Compare
|
I broke #64392 out of this to better isolate the test failures. |
…g block selection
…he editor package
MaggieCabrera
approved these changes
Aug 12, 2024
|
Ok, let's bring this in. I'm sure any unintended side effects will be best discovered by people using it, and then we can revert :) |
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
… block or clearing block selection (#64048) * Clear the insertion point when selecting a different block or clearing block selection * Use the block insertion point in the inserter, not the the one from the editor package * use block insertion point index * Don't change the insertion point when clearing block selection * Also set the insertion point in the quick inserter Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
2 tasks
2 tasks
@scruffian It looks like there are a couple of issues that were caused:
|
|
Started trying to untangle this issue: #65098 |
I feel like a prophet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds additional situations in which we clear the block insertion point. Fixes #63866
Why?
When a block is selected, it would be expected that the insertion point would also update to reflect the newly selected block, so we should reset the insertion point in this case.
How?
Add more actions to the insertion point reducer so that it detects when a block is selected.
Testing Instructions
Screenshots or screencast
Trunk
trunk.mov
This branch
fix.mov