Used color name in ColorPalette aria-label.

[jorgefilipecosta]

This improves accessibility as displaying color code is not very useful for users to understand the color.

Fixes part of: #2699

Description

In a theme that does not change the color palette or in the theme that sets the color palette with color names (mandatory now, but not using it was not yet deprecated), verify that the aria-labels for the items of the color palette specify the color names (before they always used color code).

[afercia]

Aahh @jorgefilipecosta this is awesome, thanks! 🙂

Now finally users would have a clue what that #cf2e2e color is!

A few things to consider:

• how can we kindly invite developers to add a color name when they add their own colors? Should we make the color name required?
• in the current implementation, when there's a name I'd strip out the Color name: part from the string and use just the name. It's pretty clear it's a color.
• other users would need a visible label, for example speech recognition software users would need at least tooltips to discover the control name and voice a command like, for example: "Click vivid red". Can we add tooltips? e.g.

The Custom color picker would need a tooltip as well:

Good job! 🎉

P.S. I think the snapshots need to be regenerated.

[jorgefilipecosta]

Hi @afercia, thank you for your review. Your feedback was applied labels were changed and tooltips were added.
Regarding your question:

how can we kindly invite developers to add a color name when they add their own colors? Should we make the color name required?

Given the changes to the color mechanism to use classes, it is mandatory for theme developers to set a color name, but currently, we are still accepting colors without names (for two versions I think) in order to be compatible with existing code. Warnings appear in the console saying that a change will be required.

[afercia]

Cool, thanks for the feedback @jorgefilipecosta

[mtias]

how can we kindly invite developers to add a color name when they add their own colors? Should we make the color name required?

Yes, to confirm, this should be the required way to declare colors once we drop the back compat ability!