Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Content: Add Border Support #64230

Merged
merged 10 commits into from
Aug 15, 2024
Merged

Comment Content: Add Border Support #64230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eebbb5e
Commtent Content: Add Border Support
shail-mehta Aug 4, 2024
ccd0b8d
fixed lint issue
shail-mehta Aug 4, 2024
486f885
Commtent Content: Add Border Support
shail-mehta Aug 4, 2024
1911861
Added style at root level
shail-mehta Aug 4, 2024
c4d6cbc
fixed lint issue
shail-mehta Aug 4, 2024
357b32a
Added Border box in Editor Side
shail-mehta Aug 9, 2024
125b459
Added suggested changes
shail-mehta Aug 9, 2024
77b560a
Fixed Conflict Issue
shail-mehta Aug 12, 2024
dbf5900
Removed Duplicate css
shail-mehta Aug 13, 2024
57237e1
remove editor style
shail-mehta Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/block-library/src/comment-content/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,25 @@
"fontSize": true
}
},
"__experimentalBorder": {
"radius": true,
"color": true,
"width": true,
"style": true,
"__experimentalDefaultControls": {
"radius": true,
"color": true,
"width": true,
"style": true
}
},
"spacing": {
"padding": [ "horizontal", "vertical" ],
"__experimentalDefaultControls": {
"padding": true
}
},
"html": false
}
},
"style": "wp-block-comment-content"
}
5 changes: 5 additions & 0 deletions packages/block-library/src/comment-content/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,8 @@
font-size: 0.875em;
line-height: 1.5;
}

.wp-block-comment-content {
// This block has customizable padding, border-box makes that more predictable.
box-sizing: border-box;
}
1 change: 1 addition & 0 deletions packages/block-library/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
@import "./comments-pagination/style.scss";
@import "./comment-template/style.scss";
@import "./comment-date/style.scss";
@import "./comment-content/style.scss";
@import "./cover/style.scss";
@import "./details/style.scss";
@import "./embed/style.scss";
Expand Down
Loading