Add back editor-post-locked-modal to post lock component. #64257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
spacedmonkey
requested review from
colorful-tones,
Mamaduka,
ellatrix,
tyxla and
youknowriad
|
Size Change: +1.24 kB (+0.07%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 5, 2024
Ensure the `editor-post-locked-modal` class remains unchanged because third-party plugins depend on it. This change prevents potential breakages in plugin functionality.
|
Flaky tests detected in 14e9eb6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10285311224
|
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…64257) * Add back editor-post-locked-modal to post lock component. * Add comment to preserve class in post-locked-modal Ensure the `editor-post-locked-modal` class remains unchanged because third-party plugins depend on it. This change prevents potential breakages in plugin functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The
editor-post-locked-modalclass name on the post lock component was remove in#58197
This PR brings back this class name.
Why?
This class name is useful and my team uses to customise the post locking dialog. We use it for style the component, add extra buttons and for e2e tests.
Also it means that classes like
editor-post-locked-modal__avatardo not make sense.editor-post-locked-modal__avataris meant a sub class ofeditor-post-locked-modalthat no longer exists.How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast