-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Fix Template Parts post type preload path #64401
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought that might be it. Thanks for confirming and for fixing it @Mamaduka 🙌 |
Flaky tests detected in 2bc08c2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10347976331
|
* Site Editor: Fix Template Parts post type preload path * Add backport changelog file Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
What?
PR fixes a typo in the Template Parts post-type preload path. This type has been around since the beginning—#36488.
Why?
Incorrect preload paths result in a silent WP error, and noting gets preloaded. I only noticed this because I was checking REST API responses and was curious where
WP_Error
originated.Maybe
rest_preload_api_request
should log a_doing_it_wrong()
when a provided path resolves with an error.Testing Instructions
site-editor.php?postType=wp_template_part
.types/wp_template_part
request. It does on the trunk.Testing Instructions for Keyboard
Same.
Screenshots or screencast