Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iAPI Docs: Remove typed function from API reference #64429

Merged

Conversation

luisherranz
Copy link
Member

What?

I have deleted the typing of an argument from one of the functions in the API Reference examples.

Reported here: #64418

Why?

Because TypeScript is not being used in any of the other examples, so seeing that typing can be confusing.

Copy link

github-actions bot commented Aug 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: atachibana <atachibana@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@luisherranz luisherranz added [Type] Developer Documentation Documentation for developers [Feature] Interactivity API API to add frontend interactivity to blocks. labels Aug 12, 2024
@luisherranz luisherranz linked an issue Aug 12, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sounds like a plan

@luisherranz luisherranz enabled auto-merge (squash) August 12, 2024 08:09
@luisherranz luisherranz merged commit 92ea19f into trunk Aug 12, 2024
68 of 73 checks passed
@luisherranz luisherranz deleted the iapi-docs-remove-typed-function-from-api-reference branch August 12, 2024 08:18
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 12, 2024
getdave pushed a commit that referenced this pull request Aug 14, 2024
Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: atachibana <atachibana@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Interactivity API - TypeScript snippet is used in the sample.
2 participants