Build Tools: Fix the package plugin script #6463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Build Tooling
I guess, this requires another function comment to make phpcs happy... 😄 |
gziolo
approved these changes
Apr 27, 2018
youknowriad
force-pushed
the
fix/package-plugin
branch
from
5e8e197 to
cd47c66
Compare
|
I had this fix on my git stash and forgot to make it a PR, d'oh! 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not certain this is the correct fix but there's already another polyfilled function
add_actionso to fix the package plugin script, I added a polyfill the newly used functionwp_add_inline_script.There's probably a better way to write this script but it would probably require fetching WordPress Core while the current script is independent.
Testing instructions
npm run package-plugin