Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set custom placeholder in lists #6465

Closed
wants to merge 1 commit into from

Conversation

ocean90
Copy link
Member

@ocean90 ocean90 commented Apr 27, 2018

Following #1891 for text and headings, this adds placeholder as an attribute to core/list to make the placeholder customizable when the block is used in a template.

@ocean90 ocean90 added [Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks labels Apr 27, 2018
@gziolo
Copy link
Member

gziolo commented Apr 27, 2018

Technically it would work, but it will cause that the placeholder text would be stored in HTML comments for every List block. We should seek an alternative solution which will allow to set this value in the template, but wan't be part of attributes definition. Maybe we can use supports definition instead and make placeholders customizable for all blocks.

@ZebulanStanphill
Copy link
Member

If the List block started using nesting and a List Item child block was added (see #6394), then would that make this easier?

@danielbachhuber
Copy link
Member

Closing, per:

We should seek an alternative solution which will allow to set this value in the template

@danielbachhuber danielbachhuber deleted the add/list-placeholder branch May 14, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants