-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity API: Fix context inheritance from namespaces different than the current one #64677
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix David.
…than the current one (WordPress#64677) * Add failing test * Fix contextStack generation to include other namespaces * Update changelog Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
What?
Fixes a bug introduced in the recent refactoring of the Interactivity API internals (see #62734). Noticed while merging
trunk
in #62906.Why?
The
data-wp-context
directive stopped propagating values from parent contexts using a different namespace. This broke directives trying to access values from such contexts.Testing Instructions
These changes can be tested on top of the #62906 PR.
To reproduce the issue:
trunk
in the current branch.To check the issue is fixed: