Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigator: add support for exit animation #64777

Merged
merged 32 commits into from
Sep 26, 2024
Merged

Navigator: add support for exit animation #64777

merged 32 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. Refactor screen logic for better clarity and hook deps

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ee11150 View commit details
    Browse the repository at this point in the history

  2. Add exit animation, rewrite screen animations / DOM rendering logic

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2832ef0 View commit details
    Browse the repository at this point in the history

  3. Only add inset CSS rule when animating out

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e6ab671 View commit details
    Browse the repository at this point in the history

  4. Parametrise animation

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0a869dc View commit details
    Browse the repository at this point in the history

  5. CHANGELOG

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    85b5214 View commit details
    Browse the repository at this point in the history

  6. Add fallback timeout

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7b2df6a View commit details
    Browse the repository at this point in the history

  7. Mention wrapper height in README

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9792e28 View commit details
    Browse the repository at this point in the history

  8. Use useReducedMotion() hook instead of custom logic

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    12a185f View commit details
    Browse the repository at this point in the history

  9. Extract useScreenAnimatePresence hook, tidy up

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    668a222 View commit details
    Browse the repository at this point in the history

  10. Forward animationEnd

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    98c7b20 View commit details
    Browse the repository at this point in the history

  11. Add setWrapperHeight functionality via context

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    808780e View commit details
    Browse the repository at this point in the history

  12. Use clip instead of hidden for overflow-x

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1e0ae6b View commit details
    Browse the repository at this point in the history

  13. Less aggressive clipping for screens that are animating out

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4a19bb1 View commit details
    Browse the repository at this point in the history

  14. Better sizing styles for screen, to keep it more stable while transit… 

    …ioning out
    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5dde128 View commit details
    Browse the repository at this point in the history

  15. Refine internal animation logic for less jumpy animations

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ea5f1ed View commit details
    Browse the repository at this point in the history

  16. Remove unnecessary Storybook styles

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c9e9998 View commit details
    Browse the repository at this point in the history

  17. Change wording

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    205b9aa View commit details
    Browse the repository at this point in the history

  18. Improve logic: 

    - more clear animation status names
- apply CSS animation only while effectively animating
- fix bug in the animationEnd callback which was matching animation end
  events too loosely, thus causing glitches
    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9931a50 View commit details
    Browse the repository at this point in the history

  19. Add timeout fallback for in animations too

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c98ba81 View commit details
    Browse the repository at this point in the history

  20. Fix animation delay for forwards.out animation

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d572679 View commit details
    Browse the repository at this point in the history

  21. Use display: grid instead of absolute positioning to set provider min… 

    … height

Remove unnecessary import
    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    80bddac View commit details
    Browse the repository at this point in the history

  22. Simplify navigatorScreenAnimation

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2900c46 View commit details
    Browse the repository at this point in the history

  23. Remove unnecessary state element ref

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    56a1cb9 View commit details
    Browse the repository at this point in the history

  24. Use "start" and "end" instead of "backwards" and "forwards"

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    396e3f3 View commit details
    Browse the repository at this point in the history

  25. Do not rely on usePrevious

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ec1d6a7 View commit details
    Browse the repository at this point in the history

  26. Use CSS transitions

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    effbe13 View commit details
    Browse the repository at this point in the history

  27. Fix Storybook example

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ce54ad6 View commit details
    Browse the repository at this point in the history

  28. Revert "Use CSS transitions" 

    This reverts commit 946f9c953232b788f58050d2a94d9d131527a180.
    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    759e55f View commit details
    Browse the repository at this point in the history

  29. Switch to data-attributes for less runtime emotion calculations

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3988e43 View commit details
    Browse the repository at this point in the history

  30. Add back fallback animation timeout

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b15f9af View commit details
    Browse the repository at this point in the history

  31. Move CHANGELOG entry to unreleased section

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d67f6f2 View commit details
    Browse the repository at this point in the history

  32. Clean up code, reduce diff for easier reviewing

    @ciampo
    ciampo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    283dc1e View commit details
    Browse the repository at this point in the history