-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safeguard to mediaUploadMiddleware
#64843
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +11 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
What?
Add safeguard to
mediaUploadMiddleware in case
response` isn't actually a fetch response but an error.Why?
This is something I ran into when working on client-side media processing in #64278.
There I got errors about
headers
not existing onresponse
, because it was actually an error.How?
Check if
response.headers
exists before using it.Testing Instructions
Unclear at this time, this didn't really happen outside that PR.
But you can probably reproduce this by doing this:
fetch_error
errormediaUploadMiddleware
trying to useresponse
.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A