-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add border to Replace item in content only image toolbar #64849
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +6 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Flaky tests detected in c0ceb58. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10584483425
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, let's bring this in
@jeryj do you mind resolving the conflict here? |
c0ceb58
to
15bc1b6
Compare
f5dd308
to
4de24d2
Compare
This needs a re-check, as trunk changed enough to mean I had to solve this in a new way. |
4de24d2
to
cfcfa02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of #64727
What?
Adds border around Replace item in content only image
Closes #64727
Why?
From @richtabor:
How?
Places Replace in its own BlockControls group to have borders applied by default
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast