Interactivity API: Improve internal deepMerge function
#64879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Enhancement
30 tasks
luisherranz
approved these changes
Aug 29, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the review, @luisherranz! I've addressed your feedback and polished the code a bit. It should be ready now. 🙂 |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…4879) * Move deepMerge to proxies and update implementation * Remove Boolean casting in hasPropSignal implementation * Test subscriptions to nested props updates * Remove extraneous label * Check signals are not created for nested props * Fix getProxyFromObject types * Add missing imports * Add extra assertions to ensure correct signal creation * Do not expose hasPropSignal from proxies/index * Add missing TSDocs * Update changelog Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improves the internal
deepMerge()function implementation. The main reason for these changes is to ensuredeepMerge()follows the following rules:Why?
Required by the upcoming
getServerState()andgetServerContext()functions to handle state updates from the server.How?
The new
deepMerge()implementation directly manipulates the objects behind state proxies. If an existing property value is updated, it checks whether a correspondingPropSignalinstance exists. Only in that case are the signal values updated.Testing Instructions
I added unit tests for the three rules mentioned above.