-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Bindings: Rely on Text
component instead of Truncate
in bindings panel
#65007
Block Bindings: Rely on Text
component instead of Truncate
in bindings panel
#65007
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -12 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What?
Remove usage of
Truncate
component and rely onText
component withtruncate
prop in the bindings panel.Why?
It seems
Truncate
is not needed, and it will help with style consistency. It should palliate the issue mentioned here. And ifText
styles change in the future, it will just work as expected.Additionally, it removes an extra
span
from the HTML.How?
Using the
truncate
prop of theText
component.Testing Instructions