Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add parameter to display featured image caption #65022

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

efu98
Copy link

@efu98 efu98 commented Sep 3, 2024

What?

Add an option to display caption on featured image block

Why?

Closes #40946

How?

Added a new toggle control to display featured image caption

Testing Instructions

  1. Upload an image
  2. Add a caption to the image
  3. Open a post or page
  4. Set the featured image to the image you've just uploaded
  5. Enable "Display caption"

Testing Instructions for Keyboard

Screenshots or screencast

displaycaption

Copy link

github-actions bot commented Sep 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @kaffeeringe, @greening, @jethin, @janvitos, @kevinpoot, @belisama, @supernovia, @dhanson-wp, @noellesteegs, @jordonrupp-dev.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: kaffeeringe, greening, jethin, janvitos, kevinpoot, belisama, supernovia, dhanson-wp, noellesteegs, jordonrupp-dev.

Co-authored-by: efu98 <elfu98@git.wordpress.org>
Co-authored-by: hagege <hage@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: nickbohle <nickbohle@git.wordpress.org>
Co-authored-by: iamtakashi <iamtakashi@git.wordpress.org>
Co-authored-by: samiff <samiff@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @efu98! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Post Featured Image Affects the Post Featured Image Block labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Featured Image Affects the Post Featured Image Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Post Featured Image]: add option to display image caption/credit
2 participants