Update: Rephrase "Force page reload" and move to Advanced #65081
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
requested review from
jameskoster,
richtabor,
luisherranz and
a team
|
Size Change: +1.29 kB (+0.07%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
update/force-reload
branch
from
eb52dd5
to
d0270d6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jarekmorawski, @michaelpick. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 660cd82. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10718895364
|
|
Makes sense to me. 
Perhaps we should remove the reference to "Force page reload" in the help text copy here? The sentence could just begin "Cannot be disabled because...". |
|
Good note, done! |
jameskoster
reviewed
Sep 5, 2024
packages/block-library/src/query/edit/inspector-controls/enhanced-pagination-control.js
Outdated
Show resolved
Hide resolved
gziolo
reviewed
Sep 5, 2024
| ); | ||
| } else if ( hasUnsupportedBlocks ) { | ||
| help = __( | ||
| "Force page reload can't be disabled because there are non-compatible blocks inside the Query block." | ||
| "Reload full page can't be disabled because there are non-compatible blocks inside the Query block." |
There was a problem hiding this comment.
One important note. When there are non-compatible blocks, then the full page navigation, as in older WordPress versions, needs to happen. I think it's what it says but it's still confusing for me. Eventually, we should aim to remove this compatibility check and instead handle everything on the front end using a progressive enhancement approach. For example, when the partial page change withouth full reload is enabled, we try to go to the next page and if Interactivity API detects something went wrong, it should fall back to the usual behavior when someone click a link.
|
I like where it is going. I'd like to explore how to remove the compatibility check and related warning as briefly explained in #65081 (comment). |
…ced-pagination-control.js Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
|
Applied suggestions. |
gziolo
approved these changes
Sep 6, 2024
gziolo
added
[Block] Query Loop
gziolo
reviewed
Sep 6, 2024
packages/block-library/src/query/edit/inspector-controls/enhanced-pagination-control.js
Outdated
Show resolved
Hide resolved
…ced-pagination-control.js
afercia
reviewed
Sep 9, 2024
| @@ -25,19 +25,19 @@ export default function EnhancedPaginationControl( { | |||
| ); | |||
| } else if ( enhancedPagination ) { | |||
| help = __( | |||
| "Browsing between pages won't require a full page reload, unless non-compatible blocks are detected." | |||
| 'Reload the full page—instead of just the posts list—when visitors navigate between pages.' | |||
There was a problem hiding this comment.
I'm not sure this is correct.
afercia
reviewed
Sep 9, 2024
| ); | ||
| } else if ( hasUnsupportedBlocks ) { | ||
| help = __( | ||
| "Force page reload can't be disabled because there are non-compatible blocks inside the Query block." | ||
| 'Enhancement disabled because there are non-compatible blocks inside the Query block.' |
There was a problem hiding this comment.
The word 'enhancement' is still biased as it assumes one of the two navigation model is, in a way., 'better'. As I mentioned in #63599 (comment), to me WordPress should not make any assumption on what kind of experience is 'better' for users. It should present the feature in a neutral way,
There was a problem hiding this comment.
Agreed on not using words like "enhancement" which are going to be contextual and instead describing how things work in a way people can understand.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #63599. Updates the phrasing of the force page reload setting, and moves it to the Advanced section.
Before:
After:
Why?
The phrasing is confusing, as is the intricate behavior of the control itself.
Testing Instructions
Insert a query loop, and observe the control in the inspector.