Media placeholders: Add "drag" to the text. #65149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -10 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 02a5a8f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10772454311
|
jameskoster
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The current Image block placeholder text reads this:
There's very similar text for Audio and Video. Screenshots:
The fact that you can drag an image, video, or audio file from anywhere, your desktop or the media tab in the inserter, is not clear from this text, yet is arguably a more important affordance than that of adding images via a URL. Since the third button already says "Insert from URL", we can potentially omit that part, both simplifying the overall text, and include that you can drag media. Suggested text:
Screenshot:
Testing Instructions
Insert image, video, and audio blocks in their empty state, in a wide desktop context, and observe the updated text.