Close inserter on exiting Zoom Out to edit #65194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
requested review from
draganescu,
scruffian,
jeryj,
richtabor and
MaggieCabrera
|
It feels a little hacky having to rely on a block editor setting here. I would prefer if there was a means to subscribe to an action in another store and then dispatch an action. There might be one I'm not aware of... |
|
@getdave, batching shouldn't be required at the moment. The |
|
Size Change: +66 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
I think we should avoid a hasty abstraction here and just call the |
draganescu
reviewed
Sep 10, 2024
There was a problem hiding this comment.
It seems this action is getting more stuff on its plate. Is this a correct approach? Should it dispatch something that closes the inserter and something that selects the correct block? Or, maybe, should we instead subscribe to SET_EDITOR_MODEand react by closing the inserter and setting the proper selection?
|
I would only want to close the inserter when double clicking or using the edit button. I don't think toggling the top level zoom out button in the header should also close the inserter. |
This comment was marked as outdated.
This comment was marked as outdated.
getdave
force-pushed
the
update/close-inserter-on-exit-zoom-out
branch
from
4ba19b4
to
42ba373
Compare
getdave
commented
Sep 11, 2024
Comment on lines
+37
to
+43
| const { __experimentalSetIsInserterOpened } = getSettings(); | ||
|
|
||
| if ( | ||
| typeof __experimentalSetIsInserterOpened === 'function' | ||
| ) { | ||
| __experimentalSetIsInserterOpened( false ); | ||
| } |
There was a problem hiding this comment.
This pattern follows the advice in #64573 (comment)
I've updated this PR to do this. LMK what you think @scruffian @jeryj. |
getdave
changed the title
@draganescu It's not the right approach. I updated it to a simpler option which doesn't overburden the action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes any open inserter when exiting Zoom Out when the user explicit opts to "edit" the content.
Closes #65161
Why?
See #65161.
How?
Call the relevant function provided on editor settings if available when the current mode is switching to non-zoom out.
Concerns
I'm not entirely happy with this approach for various reasons.
Do we want to always close the inserter when exiting Zoom Out or just in certain scenarios?Should we be batching the dispatch calls within__unstableSetEditorMode()? (cc @Mamaduka)setEditorMode?Testing Instructions
Editicon in the zoom out toolbarTesting Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-09-10.at.12-36-25.mp4