Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views post list: check for id before coercing to string #65227

Closed
wants to merge 2 commits into from
Closed

Data views post list: check for id before coercing to string #65227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3e0007
Check for id on missing records. Needed for when there are no records…
ramonjd Sep 11, 2024
28a541b
simplify return value
ramonjd Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/post-list/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ function useView( postType ) {
const DEFAULT_STATUSES = 'draft,future,pending,private,publish'; // All but 'trash'.

function getItemId( item ) {
return item.id.toString();
return item?.id.toString();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case, we call this with an empty "item"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. This PR is just to stop the browser crashing.

}

export default function PostList( { postType } ) {
Expand Down
Loading