Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useEvent from components package #65388

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

DaniGuardiola
Copy link
Contributor

What?

Remove a duplicated utility from the components package now that it's available in the @wordpress/compose package (#64943).

How?

Removed the utility and replaced imports with compose.

Copy link

github-actions bot commented Sep 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@DaniGuardiola DaniGuardiola self-assigned this Sep 17, 2024
@DaniGuardiola DaniGuardiola added [Package] Components /packages/components [Type] Enhancement A suggestion for improvement. labels Sep 17, 2024
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks 🚀

Should we add a CHANGELOG entry?

@DaniGuardiola DaniGuardiola merged commit 56bfef8 into trunk Sep 19, 2024
68 of 70 checks passed
@DaniGuardiola DaniGuardiola deleted the feat/remove-outdated-use-event-util branch September 19, 2024 13:37
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 19, 2024
@DaniGuardiola
Copy link
Contributor Author

@tyxla I don't think a changelog entry is worth it. It's barely a housekeeping task, the minor-est of cleanups :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants