Make sections contentOnly in Zoom Out
#65396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -4 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
I am not sure I understand this, why do we need it? After #65204 lands can't we use the same inner workings as there if we want edit mode to be in compose mode? |
We might end up with that but if that PR doesn't land then we still need this behaviour on top level sections. Can go in the holding tank for now and we can merge/not merge later. However, it's useful for demoing (I've seen a lot of confusion) and also the code would certainly be removed if/when we normalized towards the mode in #65204. |
talldan
reviewed
Sep 18, 2024
Comment on lines
+2949
to
2951
| if ( sectionsClientIds?.includes( clientId ) ) { | ||
| return 'contentOnly'; | ||
| } |
There was a problem hiding this comment.
While it might set the section to contentOnly block editing mode, the inner content blocks don't seem to be editable when I tested it.
contentOnly block editing mode is different to contentOnly template lock. The block editing mode only affects the current client id and not the inner blocks of the current client id.
To make the content blocks contentOnly I think you'll need to use __experimentalHasContentRoleAttribute like the code a few lines below this to determine whether a block is a content block.
There was a problem hiding this comment.
If I'm understanding you correctly (please say if I'm not) then that is exactly what I want to happen in this PR.
In "zoom out" the intent is that only the sections themselves are editable (for now) and not the inner blocks.
If other efforts around content only don't land, then we might want to adjust zoom out behaviour to do what you suggest.
Let me know if thats confusing or something seems off.
There was a problem hiding this comment.
Ah, ok, I have the wrong end of the stick then. I thought the goal would be to make content editable in zoom out. I guess the advantage of using contentOnly in the way this PR does it to reduce the number of inspector controls?
There was a problem hiding this comment.
Yes that's right.
In the future we anticipate making all the "content" blocks editable but for now we are sticking with only being able to select top level "sections".
....to reduce the number of inspector controls?
Yes that's the idea. If you select a section you shouldn't be overwhelmed with layout options on the section.
talldan
approved these changes
Sep 18, 2024
getdave
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 19, 2024
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 1df4bb0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes all section blocks
contentOnlyin Zoom Out mode.Why?
Removing unnecessary UI and cleaning up the interface to focus on the content. Also ensures things like transforms are hidden once #65394 is merged.
How?
Returns
contentOnlyfrom thegetBlockEditingModeselector for sections when in zoom out mode.Testing Instructions
contentOnly.Testing Instructions for Keyboard
Screenshots or screencast