Match visible label of search inputs with their actual label. #65458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
afercia
requested review from
getdave,
ellatrix and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -84 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/search-inputs-placeholder-label-mismatch
branch
from
0760edd to
7c5dc4e
Compare
afercia
force-pushed
the
fix/search-inputs-placeholder-label-mismatch
branch
from
7c5dc4e to
9f86d17
Compare
|
The labels changed in this PR are not visible, so this seems fine to me if it improves a11y. |
|
Thanks @jameskoster. I'd appreciate a final review and approval Cc @WordPress/gutenberg-core |
mirka
approved these changes
Oct 7, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…ess#65458) * Match visible label of search inputs with their actual label. * Adjust more tests. * Adjust more tests. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65235
What?
The visible label of some search inputs mismatches their actual accessible name.
This is a barrier for some users, most notably sighted screen reader users and voice control users.
Why?
Important
It is worth reminding a few principles:
I would like the principles above to be included in the design guidelines Cc @WordPress/gutenberg-design
How?
SearchControland other search inputs use the same text for the label and the placeholder.ria-labelledbyis meant to be user to point to visible text. See Visually hide the LinkControl initial/results heading #50977 (comment)Testing Instructions
SuggestionsSearch results for "%s"Testing Instructions for Keyboard
Screenshots or screencast