-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post editor: fix meta boxes accessibility #65466
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +456 B (+0.03%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Thanks for the PR! I'd like to test this PR in detail later, but one thing I noticed is that when the resize handle is focused, pressing the up and down keys may lose focus. I checked out #65325 (07c6a1f), which implemented a custom resize handle, and tested this problem, and I was able to reproduce the problem in my environment. And, although the behavior is slightly different, this problem also occurs in this PR. We might have to investigate and fix this issue first. Below is a video that reproduces the problem in trunk: 688adb4e968556f21270dfa730aa77e0.mp4By the way, I submitted a PR to the Even if that PR is merged, backporting it to WP 6.7 may have a big impact. Therefore, we might consider shipping this PR at the time of WP 6.7 and updating the library in WP 6.8. |
It looks like this problem can be solved just by adding gutenberg/packages/edit-post/src/components/layout/index.js Lines 280 to 281 in e691b04
|
What?
A couple of fixes for a11y issues:
Why?
To fix #65406.
How?
details
element with an alternative that hides the meta boxes visually without removing them from the accessibility tree. Note:ResizableBox
with custom code doing the same job. Notes:ResizableBox
and that’s a limitation of the library it’s built with. The only other option (save perilous hacks) is to wrap theVisualEditor
in the component instead to meet the expected tab order. That option is viable but it’s more work and would require some changes in the editor package to be done in a way that doesn’t duplicate some code.Testing Instructions for Keyboard
Have a plugin activated that creates meta boxes or have the custom fields preference on and open a post or page in the Post editor.
Toggle (short viewport)
Tab order (not short viewport)