Command Palette: "Add new page" within the site editor creates new page in site editor #65476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
commented
Sep 19, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
the
Backport to WP 6.7 Beta/RC
|
I added the backport to WP 6.7 since this is a small, but absolutely fantastic value-add. (In my opinion) 😄 |
|
Size Change: -2.17 kB (-0.12%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ramonjd
commented
Sep 19, 2024
|
Okay, the command now lives in site editor and the e2e should pass 🤞🏻 Thanks @andrewserong ! |
|
Thanks Ramon! I'll take this for a spin tomorrow 👍 |
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Sep 19, 2024
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
|
Just pushed a tiny commit to update the package-lock file as the linter was complaining 🙂 |
andrewserong
approved these changes
Sep 20, 2024
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 20, 2024
…ge in site editor (#65476) The add page command will now create a new page depending on context: in the post editor it will redirect to `postType=page` in the post editor as it did previously. In the site editor however, it will open a new page without redirecting to the post editor. --------- Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: a784d78 |
github-actions
bot
added
the
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #65473
What?
First pass at forking the add page command depending on context.
Why?
@andrewserong is right - it's a bit disconcerting to be taken away from the site editor when creating a new page.
How?
Forking the command based on the environment (whether
site-editor.phpis in the URL, which seems to be the most common mode of detection)Testing Instructions
In the site editor, open the command center (Cmd/Ctrl + K) and type/select "Add new page"
A new page should be created in the site editor.
Do the same in the post editor, you should stay in the post editor.
Testing Instructions for Keyboard
Screenshots or screencast
Kapture.2024-09-19.at.13.10.14.mp4