-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icon in home button #65497
base: trunk
Are you sure you want to change the base?
Update icon in home button #65497
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -36 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Flaky tests detected in 1c5d3e4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10945147467
|
I'm not sure a diagonal arrow helps understand the functionality.
|
@afercia agree those are issues to fix, but probably not here. More options: |
The "menu" icon seems as good as it gets for now. Regarding future concerns, if admin bar functionality would stretch the metaphor too much perhaps such functions merit their own UI. |
Closes #65428.
What?
Replace the current icon in the home button.
Why?
See #65428.
How?
In this PR I swapped to the
menu
icon. It's not perfect because the explicit metaphor may not fully capture how this element might evolve in the future (absorbing admin bar functionality). However, it is a very familiar icon, and aligns with the current tooltip 'Open navigation'.Other options I ruled out:
<
isn't appropriate because it suggests going back, which isn't always the resulting behavior. We've already iterated away from this once (Update: chevron to home icon. #64161).We can explore new alternative icons here too.
One option could be something like the 'exit full screen' icon in macOS (green button):
Another option could be a diagonal arrow: