Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keywords to query loop block #65515

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

dhruvang21
Copy link
Contributor

@dhruvang21 dhruvang21 commented Sep 20, 2024

What?

Resolves issue : - 65493

Why?

To help make query loop block more discoverable.

How?

By adding following keywords key to packages/block-library/src/query/block.json which includes some common terms or aliases, such as:

  • posts
  • list
  • blog
  • blogs
  • post types

Copy link

github-actions bot commented Sep 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvang21 <dhruvang21@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mikachan mikachan added [Type] Enhancement A suggestion for improvement. [Block] Query Loop Affects the Query Loop Block labels Sep 20, 2024
@mikachan mikachan linked an issue Sep 20, 2024 that may be closed by this pull request
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks so much for working on it @dhruvang21! I've made a tiny suggestion to add the word "custom", but otherwise, I think this is ready to bring in!

packages/block-library/src/query/block.json Outdated Show resolved Hide resolved
Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change, LGTM!

@mikachan mikachan merged commit 27fe952 into WordPress:trunk Sep 20, 2024
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Loop: Add keywords to help make block more discoverable
2 participants